use chain serial rather than logical index with _DefaultTrace.insert#1590
Merged
OriolAbril merged 2 commits intoarviz-devs:mainfrom Mar 3, 2021
Merged
use chain serial rather than logical index with _DefaultTrace.insert#1590OriolAbril merged 2 commits intoarviz-devs:mainfrom
OriolAbril merged 2 commits intoarviz-devs:mainfrom
Conversation
Member
|
Looks good, thanks. It should probably be also added to pymc-devs/pymc#4489 better, which is where the converter will live in 4.0+ |
Contributor
Author
|
Thanks, I've pushed the change directly to the |
OriolAbril
approved these changes
Mar 2, 2021
Member
|
Can you add it to maintenance and fixes in the changelog? I think it is good to merge after that |
Contributor
Author
|
Yep, done! (Not sure you'd get a notification after a commit push? Hence this comment :) ) |
Member
|
Thanks! |
utkarsh-maheshwari
pushed a commit
to utkarsh-maheshwari/arviz
that referenced
this pull request
May 27, 2021
…rviz-devs#1590) * use chain serial rather than logical index with _DefaultTrace.insert * add PR arviz-devs#1590 to changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a fix for an issue in PyMC3: pymc-devs/pymc#4469 . A trace could have chains that are not necessarily indexed 0, 1, .... However,
_DefaultTrace.insertdoes take an index 0, 1, ... So, the index argument intoinsertshould be zero-based. This PR decouples thechainindex (which refers to a logical chain index, possibly starting at 1 or whatever) from the index passed to_DefaultTrace.insert.